Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.15 RFE] Adding views and entities for sca alerts on 6.15 #1026

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[6.15 RFE] Adding views and entities for sca alerts on 6.15 #1026

wants to merge 3 commits into from

Conversation

ColeHiggins2
Copy link
Member

These additions are for getting the sca-alerts for the latest 6.15 Feature.

Jira: SAT-20200

Robottelo: SatelliteQE/robottelo#13004

@ColeHiggins2 ColeHiggins2 added the No-CherryPick PR doesnt need CherryPick to previous branches label Nov 2, 2023
@ColeHiggins2 ColeHiggins2 self-assigned this Nov 2, 2023
@ColeHiggins2 ColeHiggins2 marked this pull request as draft November 2, 2023 19:13
@ColeHiggins2 ColeHiggins2 mentioned this pull request Nov 2, 2023
Merged
@ColeHiggins2 ColeHiggins2 marked this pull request as ready for review November 27, 2023 19:35
sambible
sambible approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@sambible sambible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just remove that comment and ACK

airgun/entities/subscription.py Outdated Show resolved Hide resolved
@ColeHiggins2 ColeHiggins2 added CherryPick PR needs CherryPick to previous branches 6.15.z and removed No-CherryPick PR doesnt need CherryPick to previous branches labels Nov 30, 2023
@ColeHiggins2 ColeHiggins2 changed the base branch from master to 6.15.z November 30, 2023 16:12
@ColeHiggins2 ColeHiggins2 added No-CherryPick PR doesnt need CherryPick to previous branches and removed CherryPick PR needs CherryPick to previous branches 6.15.z labels Nov 30, 2023
@ColeHiggins2 ColeHiggins2 changed the base branch from 6.15.z to master December 11, 2023 13:37
@ColeHiggins2 ColeHiggins2 mentioned this pull request Dec 11, 2023
Merged
Gauravtalreja1
Gauravtalreja1 approved these changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@Gauravtalreja1 Gauravtalreja1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK codewise, @ColeHiggins2 Could you rebase and run the PRT here?

Gauravtalreja1
Gauravtalreja1 reviewed Jan 4, 2024
View reviewed changes
airgun/entities/subscription.py
Comment on lines +181 to +183
def sca_alert(self):
view = self.navigate_to(self, 'All')
wait_for(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SatelliteQE/robottelo#13407 (comment)

@omkarkhatavkar
Copy link

@ColeHiggins2 Ping. are you done with changes on this PR?

pnovotny
pnovotny approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@pnovotny pnovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise LGTM.
Given the age of this PR, I would rebase and also add labels CherryPick & 6.15.z.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

@sambible sambible sambible approved these changes

@pnovotny pnovotny pnovotny approved these changes

Assignees

@ColeHiggins2 ColeHiggins2

Labels
No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ColeHiggins2 @omkarkhatavkar @pnovotny @sambible @Gauravtalreja1